search

nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
10.05k stars 1.3k forks source link

Add Router component in uplink #2766

Closed thomas-bc closed 3 months ago

thomas-bc commented 3 months ago
Related Issue(s) https://github.com/nasa/fprime/issues/2765
Has Unit Tests (y/n) y
Documentation Included (y/n) TODO

Change Description

Implements https://github.com/nasa/fprime/issues/2765

Rationale

See https://github.com/nasa/fprime/issues/2765

Testing/Review Recommendations

Deframer UTs are expected to fail at this point, since some functionality was removed. We may want to work on a feature branch until all Router, Accumulator and Deframer-refactor are implemented and tests are adapted

Still opening this for preliminary review and CI checks

Future Work

Joshua-Anderson commented 3 months ago

Router might be a bit of an overloaded name, since lots of things can be routed within fprime deployments.

What about calling this FprimePktRouter - indicating this is a component for routing fprime packet formatted packets? (admittingly a bit of a mouthful, very open to different suggestions)

thomas-bc commented 3 months ago

Agreed! Router is a little too generic Closing until we coordinate the splitting of Deframer