search

nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
10.05k stars 1.3k forks source link

command_res is active but does not have async_input port #451

Closed billallen256 closed 3 years ago

billallen256 commented 3 years ago
F´ Version current
Affected Component Autocoder

Problem Description

command_res is kind="active": https://github.com/nasa/fprime/blob/devel/Autocoders/Python/test/command_res/Test1ComponentAi.xml

However, it does not have an async_input port as required by the schematron spec: https://github.com/nasa/fprime/blob/devel/Autocoders/Python/schema/default/active_comp_schematron.rng

How to Reproduce

This was found by enabling exceptions for schematron validation failures (see #325).

Expected Behavior

Change component so it passes validation and passes gtests.

LeStarch commented 3 years ago

I think the correct fix is to make this line an "async_input"

https://github.com/nasa/fprime/blob/eaf57af03f0c074881c3a83c0b5325cb9906fcae/Autocoders/Python/test/command_res/Test1ComponentAi.xml#L47

LeStarch commented 3 years ago

See #455