nasa / gesdisc-meditor

MIT License
7 stars 2 forks source link

Feature/remove any references to ges disc servers from the meditor codebase #33

Closed KrupaRami closed 11 months ago

KrupaRami commented 11 months ago

This PR contains removal of references to GES DISC servers and people from codebase to support open sourcing meditor. Changes are as follows,

benforshey commented 11 months ago

Hey, I really like the idea behind this PR—especially when it comes to our fixtures! There are a few places where I still have questions:

KrupaRami commented 11 months ago

Hey, I like the idea of using environment variables. I have kept @nasa.gov because we will still use meditor for any NASA website even after open sourcing it but it is using fake users. Do you want to discuss about using environment variables sometime today?

benforshey commented 11 months ago

Hey, I like the idea of using environment variables. I have kept @nasa.gov because we will still use meditor for any NASA website even after open sourcing it but it is using fake users. Do you want to discuss about using environment variables sometime today?

Cool, let's discuss! See you on Gather. 👍🏼

Just to clarify about the email addresses, I'm great with hashbrowns@nasa.gov, but was wondering if we should also change real email addresses like gsfc-nasa-disc.