nasa / gunns

The NASA General-Use Nodal Network Solver (GUNNS) software
Other
43 stars 11 forks source link

Various bug fixes, compiler warning fixes, and spelling fixes #113

Closed DanielGhan closed 1 month ago

DanielGhan commented 1 month ago

The primary goal of this merge request is to eliminate most of the compiler warnings coming from GUNNS. I'm working on a project that has GUNNS as a submodule and want to be able to turn on a bunch of warning flags without being overwhelmed by all the warnings coming out of GUNNS. Most of these changes are explicitly spelling out when a variable is being converted to a different type. Many of them are not really necessary, but they prevent warnings like -Wconversion, -Wfloat-conversion, and -Wdouble-promotion. Sometimes, those flags catch actual bugs that cause a loss of precision; there were a few cases of that here, where doubles were being passed into powf instead of pow. This merge request also fixes some more serious bugs, mostly instances where virtual method overrides were not overriding as intended. Finally, I fixed a bunch of spelling errors as I came across them.