Duplicated ThermAspectGenerate code

nasa / gunns

The NASA General-Use Nodal Network Solver (GUNNS) software

Other

46 stars 12 forks source link

Closed jasonlharvey closed 4 weeks ago

jasonlharvey commented 2 months ago

There seems to be duplicate copies of the ThermAspectGenerate code at:

gunns/aspects/thermal/network/bin/ThermAspectGenerate/

and

gunns/gunns-ts-models/bin/ThermAspectGenerate/

Find out from the user community which one of these copies is used and delete the unused copy.

jasonlharvey commented 4 weeks ago

Going to delete the one in gunns-ts-models, because:

These are almost identical, the most significant difference is that gunns/gunns-ts-models/bin/ThermAspectGenerate/test/TestThermAspectGenerate.py adds an unused reference to TS_ISS_HOME, which is old TS-21 specific project stuff, which doesn't belong anymore.
the xEMU PLSS project uses the version in aspects/thermal.