Closed owenlittlejohns closed 8 months ago
Take out the elusive sds's:
@lyonthefrog - good catches. I made some changes in the latest commit to fix most of those:
exceptions.py
module. I made that just "harmony-browse-image-generator" and made it a variable, so it only ever needs to be tweaked once.build-test
and build-image
.service.Dockerfile
and tests.Dockerfile
.CHANGELOG.md
, as that is trying to say that v1.0.0 is the same as v0.0.11
of the old sds-related Docker image.The HyBIG regression tests were successful, as were the unit tests (report below). And it appears that the Snyk checks below have passed.
Description
This PR implements CI/CD to run the
unittest
suite for all PRs. It also adds a Docker image publication workflow for when changes are merged into themain
branch containing an update todocker/service_version.txt
.The workflows are essentially copies of those used in the HOSS and Swath Projector repositories.
Jira Issue ID
DAS-2070
Local Test Steps
It's probably good to check the
bin/build-image
,bin/build-test
andbin/run-test
scripts all work on your local machine (given the change in image name).You can also test this all works with Harmony locally:
bin/build-image
.packages/util/env-defaults
updateHYBIG_SERVICE_QUEUE_URLS
to use an image name ofghcr.io/nasa/harmony-browse-image-generator:latest
. (It should just be a case of replacingsds
withghcr.io/nasa
)services/harmony/env-defaults
update the HyBIG image:HYBIG_IMAGE=ghcr.io/nasa/harmony-browse-image-generator:latest
.npm run build-all
.bin/bootstrap-harmony
.HARMONY_HOST_URL='http:localhost:3000'
. The tests should run and complete.Things to look for on this PR itself:
PR Acceptance Checklist
(Already prepared for v1.0.0)CHANGELOG.md
updated to include high level summary of PR changes.(Already at 1.0.0)docker/service_version.txt
updated if publishing a release.Tests added/updated and passing.(No new tests needed)