nasa / harmony-browse-image-generator

Other
1 stars 3 forks source link

Implement pre-commit hooks. #3

Closed owenlittlejohns closed 3 months ago

owenlittlejohns commented 3 months ago

Description

This PR begins the process of applying automated checking to all commits via pre-commit hooks. Currently it checks a small number of things:

Why haven't I added mypy? So far all these checks have left the service code untouched. I think we should totally add both mypy, but just wanted to get the ball rolling here.

Jira Issue ID

N/A - this is an IP-ish bit of fun.

Local Test Steps

PR Acceptance Checklist

owenlittlejohns commented 3 months ago

Just preserving this here:

There are incompatibilities between black and pycodestyle. A future goal is to make the same black and ruff checks run in the CI/CD. When we do that, I think we should nix the pylint and pycodestyle checks in favour of black and ruff.