Closed owenlittlejohns closed 3 months ago
Just preserving this here:
There are incompatibilities between black and pycodestyle. A future goal is to make the same black
and ruff
checks run in the CI/CD. When we do that, I think we should nix the pylint
and pycodestyle
checks in favour of black
and ruff
.
Description
This PR begins the process of applying automated checking to all commits via pre-commit hooks. Currently it checks a small number of things:
ruff
linting.black
code formattingWhy haven't I added
mypy
? So far all these checks have left the service code untouched. I think we should totally add bothmypy
, but just wanted to get the ball rolling here.Jira Issue ID
N/A - this is an IP-ish bit of fun.
Local Test Steps
pre-commit
.git add
thengit commit
. You should see the checks all run when you are trying to usegit commit
.PR Acceptance Checklist
Jira ticket acceptance criteria met.CHANGELOG.md
updated to include high level summary of PR changes.VERSION
updated if publishing a release.