nasa / harmony-py

Python client library for working with NASA’s Earth observing system data using Harmony. https://harmony.earthdata.nasa.gov
Other
50 stars 20 forks source link

HARMONY-1762: Switch to passing variables in the query parameters #85

Closed chris-durbin closed 4 months ago

chris-durbin commented 5 months ago

Jira Issue ID

HARMONY-1762

Description

Change to pass the variables in the query parameters using parameter_vars so that we can support requests with 4000+ variables.

Local Test Steps

I tested with the intro_tutorial notebook and modifying the request to use a bounding box instead of a shapefile (the request_as_url and request_as_curl methods do not work with a shapefile).

Add a couple print statements to the notebooks to see what the URL looks like: print(harmony_client.request_as_url(request)) print(harmony_client.request_as_curl(request))

Make sure you see it uses parameter_vars and the variable is included in the query parameters.

Also test removing the variables altogether and make sure it passes variable=all.

It would be good to test with a large number of variables as well if someone has a good request for that.

PR Acceptance Checklist