search

nasa / jeod

Other
27 stars 5 forks source link

Remove unnecessary null pointer checks #4

Closed elfring closed 1 year ago

elfring commented 1 year ago

An extra null pointer check is not needed in functions like the following.

excaliburtb commented 1 year ago

Thanks for the comment. Captured and will work

elfring commented 1 year ago

:thought_balloon: Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

excaliburtb commented 1 year ago

we're always interested in improving our tooling. time is always against us as I'm sure you can understand. I'm aware of the tool but I haven't put it on my TODO list until now. thanks

zli0 commented 1 year ago

issue addressed in JEOD v5.1

elfring commented 1 year ago

:thought_balloon: I would find an other commit message more helpful for this issue than the information “merge trunk into master for JEOD v5.1 release”.