Overview

What is the feature?

Order options fails in Forms XML for character limit although the character limit wasn't exceeded Also noticed that on form load, existing errors would not appear.

What is the Solution?

Updated order options schema and removed the char limits. Also made updates to the form logic so that only "new" records have special logic where it hides the error until the field is visited.

What areas of the application does this impact?

Order Options and Groups Form.

Testing

Easiest way to test this is to use CMR graphql to ingest a order option where the form xml > 1024 characters. It should now load into the form, not show an error, and allow you to publish a order option with a length more than 1024 characters.

To test the other bug fix, upload an order option where the name is > 85 characters directly via CMR graphql. When the form comes up, you should see an error. Same thing can be done with group page, upload a new group where the name is > 85 characters, the form should show an error when loading into MMT form.

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

[X] I have added automated tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings

nasa / mmt

MMT-3848: Order options fails in Forms XML for character limit although the character limit wasn't exceeded #1274