nasa / ncompare

Compare the structure of two netCDF files at the command line
https://ncompare.readthedocs.io
Apache License 2.0
27 stars 9 forks source link

relax upper bound constraints of dependencies #236

Closed danielfromearth closed 4 months ago

danielfromearth commented 5 months ago

GitHub Issue: #231

Description

This change removes the upper bound constraints on dependency versions in pyproject.toml.

Overview of integration done

Passed CI tests.

PR Acceptance Checklist


📚 Documentation preview 📚: https://ncompare--236.org.readthedocs.build/en/236/

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.92%. Comparing base (f78e124) to head (6b41c0a). Report is 41 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #236 +/- ## ======================================== Coverage 90.92% 90.92% ======================================== Files 5 5 Lines 463 463 ======================================== Hits 421 421 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielfromearth commented 5 months ago

@jhkennedy, how does this change look to you (for addressing the issue of upper bounds on dependencies)?

danielfromearth commented 4 months ago

Yes, exactly! Does xarray need the upper bound as well? For the upper bounds especially, the idea is they should communicate "this is a known or expected incompatibility"

I'm not sure why xarray didn't get updated when I ran poetry relax. Will manually check and update that one too.