Closed ivanperez-keera closed 10 months ago
Change Manager: Confirmed that the issue exists.
Technical Lead: Confirmed that the issue should be addressed.
Technical Lead: Issue scheduled for fixing in Ogma 1.0.12.
Fix assigned to: @ivanperez-keera.
Implementor: Solution implemented, review requested.
Change Manager: Verified that:
Solution is implemented:
FROM ubuntu:trusty
RUN apt-get update
RUN apt-get install --yes software-properties-common RUN add-apt-repository ppa:hvr/ghc RUN apt-get update
RUN apt-get install --yes ghc-8.6.5 cabal-install-2.4 RUN apt-get install --yes libz-dev
ENV PATH=/opt/ghc/8.6.5/bin:/opt/cabal/2.4/bin:$PWD/.cabal-sandbox/bin:$PATH
RUN cabal update RUN cabal v1-sandbox init RUN cabal v1-install alex happy RUN apt-get install --yes git
CMD git clone $REPO && \ cd $NAME && \ git checkout $COMMIT && \ cd .. && \ cabal v1-install $NAME/$PAT/ --enable-tests && \ cabal v1-install $NAME/$PAT/ --enable-tests --run-tests -j1
Command:
```sh
$ docker run -e "REPO=https://github.com/ivanperez-keera/ogma" -e "NAME=ogma" -e PAT="ogma-" -e "COMMIT=b9753e29f6e0823fa8bf5e639b750528438d7b31" -it ogma-test
FROM ubuntu:focal
RUN apt-get update
RUN apt-get install --yes git
SHELL ["/bin/bash", "-c"] CMD git clone $REPO \ && cd $NAME \ && git checkout $COMMIT \ && ! grep -nIHre ' $' ogma** \ && echo "Success"
Command:
```sh
$ docker run -e "REPO=https://github.com/ivanperez-keera/ogma" -e "NAME=ogma" -e PAT="ogma-" -e "COMMIT=b9753e29f6e0823fa8bf5e639b750528438d7b31" -it ogma-verify-108
Change Manager: Implementation ready to be merged.
Description
The cFS app template contains trailing spaces. It's best to remove them, since those are automatically removed by many editors and that will produce changes to the generated files.
Type
Additional context
None.
Requester
Method to check presence of bug
Searching for trailing spaces in the ogma directory brings up multiple results. It should not bring any.
Expected result
The result of the
grep
command above should be empty, indicating that there are no trailing spaces.Desired result
The result of the
grep
command above should be empty, indicating that there are no trailing spaces.Proposed solution
Remove all trailing spaces from any files that have them.
Further notes
None.