Closed ivanperez-keera closed 9 months ago
Change Manager: Confirmed that the issue exists.
Technical Lead: Confirmed that the issue should be addressed.
Technical Lead: Issue scheduled for fixing in Ogma 1.3.
Fix assigned to: @ivanperez-keera.
Implementor: Solution implemented, review requested.
Change Manager: Verified that:
Solution is implemented:
FROM ubuntu:trusty
RUN apt-get update
RUN apt-get install --yes software-properties-common RUN add-apt-repository ppa:hvr/ghc RUN apt-get update
RUN apt-get install --yes ghc-8.6.5 cabal-install-2.4 RUN apt-get install --yes libz-dev
ENV PATH=/opt/ghc/8.6.5/bin:/opt/cabal/2.4/bin:$PWD/.cabal-sandbox/bin:$PATH
RUN cabal update RUN cabal v1-sandbox init RUN cabal v1-install alex happy RUN apt-get install --yes git
CMD git clone $REPO && \ cd $NAME && \ git checkout $COMMIT && \ cd .. && \ cabal v1-install $NAME/$PAT/ --enable-tests && \ cabal v1-install $NAME/$PAT/ --enable-tests --run-tests -j1
Command:
```sh
$ docker run -e "REPO=https://github.com/NASA/ogma" -e "NAME=ogma" -e PAT="ogma-" -e "COMMIT=a590ae61f83e2a91fbbd4b5212caa228c3c0cf07" -it ogma-test
Change Manager: Implementation ready to be merged.
Description
The requirements-DB-2-Copilot backend uses an adhoc parser, instead of using the generalized JSON parser. Using the latter would simplify the code, as well as make it more versatile.
Type
Additional context
None.
Requester
Method to check presence of bug
Not applicable (not a bug).
Expected result
The specific library that deals with parsing requirement DBs is removed, and we instead rely on the generic JSON parser.
Desired result
The specific library that deals with parsing requirement DBs is removed, and we instead rely on the generic JSON parser.
Proposed solution
Express the logic of parsing the requirements DB file using the JSON parser. Remove the dedicated library for parsing requirement databases, as well as the file in
Language/Trans
.Further notes
None.