`ogma-cli`: Add dockerfile with complete workflow for ROS 2 backend including compiling the ROS app - Githubissues

nasa / ogma

Other

329 stars 24 forks source link

`ogma-cli`: Add dockerfile with complete workflow for ROS 2 backend including compiling the ROS app #136

Closed ivanperez-keera closed 4 months ago

ivanperez-keera commented 5 months ago

Description

Ogma doesn't currently generate a Dockerfile with the ROS packages. That makes it harder for users to know how to use the produce of Copilot.

Type

Feature: Complementing new feature.

Additional context

None.

Requester

Ivan Perez

Method to check presence of bug

Not applicable (not a bug).

Expected result

Running the ROS command should produce a Dockerfile with the ROS package that can be used to compile the package.

Desired result

Running the ROS command should produce a Dockerfile with the ROS package that can be used to compile the package.

Proposed solution

Add a dockerfile to the list of files produced.

Further notes

None.

ivanperez-keera commented 4 months ago

Change Manager: Confirmed that the issue exists.

ivanperez-keera commented 4 months ago

Technical Lead: Confirmed that the issue should be addressed.

ivanperez-keera commented 4 months ago

Technical Lead: Issue scheduled for fixing in Ogma 1.4.

Fix assigned to: @ivanperez-keera.

ivanperez-keera commented 4 months ago

Implementor: Solution implemented, review requested.

ivanperez-keera commented 4 months ago

Change Manager: Verified that:

Solution is implemented:
- [X] The code proposed compiles passes the tests. Details:
- Build logs:
  - https://github.com/nasa/ogma/actions/runs/9171243780/job/25215156304?pr=141
  - https://github.com/nasa/ogma/actions/runs/9171243775/job/25215156310?pr=141
- Build log archives:
  - logs_24000757623.zip
  - logs_24000757647.zip
- [X] The solution proposed fixes the issues described. Performed by visual inspection. The new CI job checks that the ros command generates a Dockerfile and builds the image.
[X] Implementation is documented. Details: The README is adjusted to instruct users to use the generated Dockerfile.
[X] Change history is clear.
[X] Commit messages are clear.
[X] Changelogs are updated.
[X] Examples are updated. Details: No examples affected.
[X] Required version bumps are evaluated. Details: Bump needed (output files generated using different structure).

ivanperez-keera commented 4 months ago

Change Manager: Implementation ready to be merged.