nasa / ogma

Generator of runtime monitors for flight and robotics applications.
Other
335 stars 25 forks source link

Cabal package homepage points to NASA.gov instead of pointing to repo #147

Closed ivanperez-keera closed 1 month ago

ivanperez-keera commented 5 months ago

Description

The cabal files indicate http://nasa.gov as the homepage for all packages. However, we don't really have an Ogma homepage on NASA gov, so it makes no sense to point to that website.

It should instead be replaced with a pointer to this repository.

Type

Additional context

None.

Requester

Method to check presence of bug

The following script checks whether https://nasa.gov is set as the homepage for any cabal packages:

$ grep -nHre '^homepage\s*:\s*http\(s\)\?:\/\/nasa.gov$' --include='*.cabal'
ogma-language-jsonspec/ogma-language-jsonspec.cabal:36:homepage:            http://nasa.gov
ogma-extra/ogma-extra.cabal:36:homepage:            http://nasa.gov
ogma-language-c/ogma-language-c.cabal:36:homepage:            http://nasa.gov
ogma-core/ogma-core.cabal:36:homepage:            http://nasa.gov
ogma-language-copilot/ogma-language-copilot.cabal:36:homepage:            http://nasa.gov
ogma-language-cocospec/ogma-language-cocospec.cabal:36:homepage:            http://nasa.gov
ogma-cli/ogma-cli.cabal:36:homepage:            http://nasa.gov
ogma-language-smv/ogma-language-smv.cabal:36:homepage:            http://nasa.gov
ogma-spec/ogma-spec.cabal:36:homepage:            http://nasa.gov

Expected result

Running the above grep command prints nothing, indicating that no cabal page lists http://nasa.gov as the homepage.

Desired result

Running the above grep command prints nothing, indicating that no cabal page lists http://nasa.gov as the homepage.

Proposed solution

Set the homepage to this repo's URL in all cabal packages.

Further notes

None.

ivanperez-keera commented 1 month ago

Change Manager: Confirmed that the issue exists.

ivanperez-keera commented 1 month ago

Technical Lead: Confirmed that the issue should be addressed.

ivanperez-keera commented 1 month ago

Technical Lead: Issue scheduled for fixing in Ogma 1.4.1.

Fix assigned to: @ivanperez-keera.

ivanperez-keera commented 1 month ago

Implementor: Solution implemented, review requested.

ivanperez-keera commented 1 month ago

Change Manager: Verified that:

ivanperez-keera commented 1 month ago

Change Manager: Implementation ready to be merged.