Closed ivanperez-keera closed 1 month ago
Change Manager: Confirmed that the issue exists.
Technical Lead: Confirmed that the issue should be addressed.
Technical Lead: Issue scheduled for fixing in Ogma 1.4.1.
Fix assigned to: @ivanperez-keera.
Implementor: Solution implemented, review requested.
Change Manager: Verified that:
Solution is implemented:
FROM ubuntu:focal
RUN apt-get update
RUN apt-get install --yes git
SHELL ["/bin/bash", "-c"] CMD git clone $REPO \ && cd $NAME \ && git checkout $COMMIT \ && ! grep -niHre '^homepage\s:\shttp(s)\?:\/\/nasa.gov$' --include='*.cabal' ogma** \ && echo "Success"
Command:
docker run -e "REPO=https://github.com/ivanperez-keera/ogma" -e "NAME=ogma" -e PAT="ogma-" -e "COMMIT=bf1de246422d625c583357616b41e027b34d9c3c" -it ogma-verify-147
Change Manager: Implementation ready to be merged.
Description
The cabal files indicate http://nasa.gov as the homepage for all packages. However, we don't really have an Ogma homepage on NASA gov, so it makes no sense to point to that website.
It should instead be replaced with a pointer to this repository.
Type
Additional context
None.
Requester
Method to check presence of bug
The following script checks whether
https://nasa.gov
is set as the homepage for any cabal packages:Expected result
Running the above grep command prints nothing, indicating that no cabal page lists
http://nasa.gov
as the homepage.Desired result
Running the above grep command prints nothing, indicating that no cabal page lists
http://nasa.gov
as the homepage.Proposed solution
Set the homepage to this repo's URL in all cabal packages.
Further notes
None.