`ogma-cli`: Problem with dependency prevents CI jobs from completing

nasa / ogma

Generator of runtime monitors for flight and robotics applications.

Other

335 stars 25 forks source link

`ogma-cli`: Problem with dependency prevents CI jobs from completing #151

Closed ivanperez-keera closed 1 month ago

ivanperez-keera commented 1 month ago

Description

jsonpath uses a function that is only available in aeson >= 2.0.3.0, but the dependency only requires aeson >= 2. This breaks the installation in the CI jobs if aeson >= 2 && aeson < 2.0.3.0 is picked.

Type

Management: fix to CI set up due to issue with dependency.

Additional context

None.

Requester

Ivan Perez.

Method to check presence of bug

Not applicable (not a bug).

Expected result

Installation in the CI jobs completes successfully.

Desired result

Installation in the CI jobs completes successfully.

Proposed solution

Add a constraint in the CI jobs to require aeson greater than 2.0.2.0.

Further notes

The issue is with a dependency, so it's not really a bug in our project. This is therefore classified as management.
The issue has been filed with jsonpath at: https://github.com/akshaymankar/jsonpath-hs/issues/48

ivanperez-keera commented 1 month ago

Change Manager: Confirmed that the issue exists.

ivanperez-keera commented 1 month ago

Technical Lead: Confirmed that the issue should be addressed.

ivanperez-keera commented 1 month ago

Technical Lead: Issue scheduled for fixing in Ogma 1.4.1. Fix assigned to: @ivanperez-keera.

ivanperez-keera commented 1 month ago

Implementor: Solution implemented, review requested.

ivanperez-keera commented 1 month ago

Change Manager: Verified that:

Solution is implemented:
- [X] The code proposed compiles passes the tests. Details:
- Build logs:
  - https://github.com/nasa/ogma/actions/runs/10977789370/job/30480152322
  - https://github.com/nasa/ogma/actions/runs/10977789368/job/30480152224
- Build log archives:
  - logs_28685896267.zip
  - logs_28685896271.zip
- [X] The solution proposed fixes the issues described. No additional checks necessary. The successful completion of the CI jobs above is all that is needed.
[X] Implementation is documented. Details: No need for updates to documentation.
[X] Change history is clear.
[X] Commit messages are clear.
[X] Changelogs are updated.
[X] Examples are updated. Details: No examples affected.
[X] Required version bumps are evaluated. Details: No update needed, change to CI job not included as part of the distributable.

ivanperez-keera commented 1 month ago

Change Manager: Implementation ready to be merged.