nasa / openmct

A web based mission control framework.
https://nasa.github.io/openmct/
Other
11.9k stars 1.23k forks source link

Object overlay views are missing object type icon and/or title #2569

Open charlesh88 opened 4 years ago

charlesh88 commented 4 years ago

Followup to #2564.

Notebook snapshot view

Viewing a Notebook entry's embedded snapshot fails to display the object type icon: Screen Shot 2019-12-09 at 6 10 59 PM

Large view

View Large passes a DOM element (the frame's objectView) into the overlay. This retains transient user manipulations of the view, like the plot's current zoom or a Tab View's currently selected tab - this has value to the user. What's missing is the object type icon, the title and context actions. Screen Shot 2019-12-09 at 11 28 53 AM

Preview

Preview uses a particular template (that includes the object title and context actions) and simply navs to an objectpath in a that context. Clicking "Preview" from an object's context menu, or clicking an object in the tree while editing displays the object in the overlay like this. The object's object-type icon is missing: Screen Shot 2019-12-09 at 11 31 30 AM

unlikelyzero commented 2 years ago

To retest in testathon