search

nasa / openmct

A web based mission control framework.
https://nasa.github.io/openmct/
Other
12.05k stars 1.25k forks source link

Sine Wave Generator enhancements for VIPER #2966

Open charlesh88 opened 4 years ago

charlesh88 commented 4 years ago

We could really benefit from some enhancements to our Example Sine Wave generator component, particularly for upcoming VIPER sims.

  1. Allow different wave shapes: sine, sawtooth, square, other?
  2. Allow setting of limits - right now the telemetry adaptor hard-codes limits to -1 and 1, which is very limiting (no pun intended). The user should be able to independently spec upper and lower limit values (leave blank for none) in the Properties.
deeptailor commented 4 years ago

@nikhilmandlik - Did you have a prototype for a square wave?

nikhilmandlik commented 4 years ago

@nikhilmandlik - Did you have a prototype for a square wave?

I do, in branch square-wave-generator, but it behave more like oscilloscope square wave as you cant have 2 points on same timestamp. Might need more tweak for our use.