nasa / openmct

A web based mission control framework.
https://nasa.github.io/openmct/
Other
12.09k stars 1.26k forks source link

Tables are showing data outside of conductor bounds #4349

Closed akhenry closed 2 years ago

akhenry commented 3 years ago

Summary

Telemetry tables are showing data with timestamps that are after the end bound of the time conductor. This is demonstrated in this example screenshot provided by the open source community:

Screen Shot 2021-10-22 at 9 16 49 AM

Expected vs Current Behavior

Telemetry tables should respect the bounds defined by the time API.

Impact Check List

akhenry commented 3 years ago

Classifying as blocker for now as this could mislead the operator if they do not realize they are seeing data outside of the range they have specified based on the assumption that it is doing this in fixed mode as well. If this behavior is not happening in fixed mode, then this could be downgraded to medium.

akhenry commented 3 years ago

Reclassifying as critical. It's an important issue, but it shouldn't block release.

akhenry commented 2 years ago

This needs investigation to see if we can reproduce in any of our environments.

scottbell commented 2 years ago

@akhenry I'm having trouble replicating this:

image

Walking through the code in the debugger, the check below should be rejecting telemetry produced after the bounds have been set: https://github.com/nasa/openmct/blob/master/src/api/telemetry/TelemetryCollection.js#L190 Perhaps somehow those bounds weren't set properly? Is this easy to see on banner? I can keep trying to replicate if so.

scottbell commented 2 years ago

Astutely @davetsay pointed out that the time conductor in the screenshot is within bounds. I’ll close this ticket.