nasa / openmct

A web based mission control framework.
https://nasa.github.io/openmct/
Other
11.99k stars 1.24k forks source link

Extraneous and invalid url params when using Open in New Tab action from certain objects #6982

Closed ozyx closed 5 months ago

ozyx commented 1 year ago

Summary

This was introduced by this PR back in 2.1.4.

Using the "Open in New Tab" action from certain objects, such as Plots and Notebooks, generates bad url params with function bodies:

http://my-url-that-openmct-is-hosted-at.com/#/browse/mine/ad025953-ef7a-4e9a-a179-01171ca9f97f?tc.mode=local&tc.startDelta=900000&tc.endDelta=15000&tc.timeSystem=utc&view=plot-single&show=%28e%2Ct%2Cn%29%3D%3E%7Bo.parentElement%3De.parentElement%2Cr%28e%2Ct%2Cn%29%7D&getViewContext=%28%29%3D%3Es%3Fs.%24refs.plotComponent.getViewContext%28%29%3A%7B%7D&destroy=function%28%29%7Br&r%28%29%7D=&getComponent=%28%29%3D%3Es&key=plot-single&parentElement=%5Bobject+HTMLDivElement%5D

Expected vs Current Behavior

URL params should NOT have stringified objects in them

Steps to Reproduce

  1. Navigate to a plot (Sine Wave Generator works for this)
  2. In the 3 dot menu, click "Open in New Tab"
  3. See borked url params

Environment

Impact Check List

Additional Information

unlikelyzero commented 1 year ago

Putting this back to medium since the telemetry or object is discoverable through other means (search and direct linking)... and that this took such a long time to surface

ozyx commented 5 months ago

Testing Instructions

rukmini-bose commented 5 months ago

Verified Testathon 3/14/2024. Tested this on various objects, and it looks gucci!