nasa / openmct

A web based mission control framework.
https://nasa.github.io/openmct/
Other
12.04k stars 1.25k forks source link

tabs should default to not load eagerly #7198

Closed davetsay closed 9 months ago

davetsay commented 11 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

scottbell commented 9 months ago

To test:

  1. Create a tabs object. The resultant form should have the eager tabs toggle switched off:

    after-default-false
  2. Change the index.html to install the plugin using the option to enable eager loading to default to true:

    openmct.install(openmct.plugins.Tabs({ eagerLoad: true }));
  3. Create a tabs object. The resultant form should have the eager tabs toggle switched on:

    after-default-true
  4. Generally test tab eager loading by creating two SWGs to drop onto the tabs object. When eager loading is turned on, on page load, both tabs object should have their component HTML loaded:

    Eager-tabs-on

When eager loading is turned off, only the selected tab on page load should have its component HTML loaded:

Eager-tabs-off
  1. Repeat with real telemetry
ozyx commented 8 months ago

Verified Testathon 2/5/24