nasa / opera-sds-ops

Apache License 2.0
4 stars 2 forks source link

initial draft of script to trigger multiple specific granules #17

Closed niarenaw closed 1 year ago

niarenaw commented 1 year ago

Purpose

philipjyoon commented 1 year ago

Looks great. Just a few minor comments:

  1. Would be good to print out in help text what a granule ID looks like so people less familiar will have confidence. Also granule IDs are space-separated list? Would be good to have a command example w a couple real granule IDs.
  2. Number of granules would be limited by the command line max on the Mozart box. Would be good to find out what that is and state that in the help text.
  3. I don't know shell programming too well but it would be better if the command string is constructed once and it's used for both dryrun and normal modes. That way you don't have two different lines of code that's constructing the same command. Prevents them from ever being out of sync in future.
riverma commented 1 year ago

LGTM! Thanks @niarenaw.