Ticket for adding an output product validation step to the DSWx-NI PGE post-processor workflow.
Since the set of expected output products for DSWx-NI is basically the same as for DSWx-S1, the goal for this ticket is to have the DSWx-NI post-processor mixin class inherit its output product validation function from the DSWx-S1 version. To accomplish this:
[x] Update the definition of the DSWxNIPostProcessorMixin to be a subclass of DSWxS1PostProcessorMixin
[x] Update DSWxNIPostProcessorMixin.run_postprocessor() such that it no longer invokes the superclass implementation, and instead it invokes the _run_sas_qa_executable() and _validate_output() methods directly, in that order (_stage_output_files() will be dealt with in a separate ticket)
[x] Add a test_dswx_ni_pge_output_validation() function to the test_dswx_ni_pge.py test suite that exercises the output product validation inherited from the DSWx-S1 PGE. To this end, the test_dswx_s1_pge_output_validation() function from test_dswx_s1_pge.py can be used as a model for this implementation
[x] Stretch goal: In a similar vein to the task above, implement a test_dswx_ni_input_validation() unit test function to the suite for DSWx-NI that exercises the input validation inherited from DSWx-S1. This should have been done with a previous ticket, but was omitted. As with the output validation test case, the test_dswx_s1_input_validation() function in test_dswx_s1_pge.py can be used as a model for the DSWx-NI version
collinss-jpl
commented
5 months ago
Ticket for adding an output product validation step to the DSWx-NI PGE post-processor workflow.
Since the set of expected output products for DSWx-NI is basically the same as for DSWx-S1, the goal for this ticket is to have the DSWx-NI post-processor mixin class inherit its output product validation function from the DSWx-S1 version. To accomplish this:
DSWxNIPostProcessorMixinto be a subclass ofDSWxS1PostProcessorMixinDSWxNIPostProcessorMixin.run_postprocessor()such that it no longer invokes the superclass implementation, and instead it invokes the_run_sas_qa_executable()and_validate_output()methods directly, in that order (_stage_output_files()will be dealt with in a separate ticket)test_dswx_ni_pge_output_validation()function to thetest_dswx_ni_pge.pytest suite that exercises the output product validation inherited from the DSWx-S1 PGE. To this end, thetest_dswx_s1_pge_output_validation()function fromtest_dswx_s1_pge.pycan be used as a model for this implementationtest_dswx_ni_input_validation()unit test function to the suite for DSWx-NI that exercises the input validation inherited from DSWx-S1. This should have been done with a previous ticket, but was omitted. As with the output validation test case, thetest_dswx_s1_input_validation()function intest_dswx_s1_pge.pycan be used as a model for the DSWx-NI version