However, this current test is too naive, in that it does not account for the following case:
The set of input CSLC static layer files has duplicate burst IDs because there are products for both S1A and S1B
What did you expect?
The test below this one (that performs straight comparison of the sets of burst IDs parsed from group of files) is probably sufficient for what we are tying to accomplish with this validation. So it should be sufficient to simply remove the naive test noted above.
Reproducible steps
1.
2.
3.
...
Environment
- Version of this software [e.g. vX.Y.Z]
- Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
...
collinss-jpl
commented
1 week ago
Checked for duplicates
Yes - I've already checked
Describe the bug
We currently perform the following check when validating the set of input CSLC burst ID's against the set of burst ID's for ancillary inputs: https://github.com/nasa/opera-sds-pge/blob/main/src/opera/util/input_validation.py#L220
However, this current test is too naive, in that it does not account for the following case:
What did you expect?
The test below this one (that performs straight comparison of the sets of burst IDs parsed from group of files) is probably sufficient for what we are tying to accomplish with this validation. So it should be sufficient to simply remove the naive test noted above.
Reproducible steps
Environment