RKuttruff
commented
2 weeks ago Ran tests, found unexpected validation test result. Same error was seen when running tests for previous version of the SAS (instance type: r6i.2xlarge), but was not documented. Reported this to ADT and am waiting for response.
$ docker run --rm --volume /home/rileykk/DISP-S1-0.4.3:/work opera/disp-s1:0.4.3 disp-s1 validate golden_output/historical/20170217_20170313.nc output/historical/20170217_20170313.nc
[INFO|validate|L495] 2024-09-09T18:38:37+0000: Comparing HDF5 contents...
[INFO|validate|L187] 2024-09-09T18:38:37+0000: Checking connected component labels...
[INFO|validate|L218] 2024-09-09T18:38:38+0000: Test unwrapped area: 68666064/69037976 (99.461%)
[INFO|validate|L219] 2024-09-09T18:38:38+0000: Reference unwrapped area: 68666069/69037976 (99.461%)
[INFO|validate|L220] 2024-09-09T18:38:38+0000: Intersection/Reference: 68666046/68666069 (100.000%)
[INFO|validate|L221] 2024-09-09T18:38:38+0000: Intersection/Union: 68666046/68666087 (100.000%)
[INFO|validate|L278] 2024-09-09T18:38:50+0000: Checking displacement...
[INFO|validate|L329] 2024-09-09T18:38:54+0000: Test nan count: 0/3209951 (0.000%)
[INFO|validate|L330] 2024-09-09T18:38:54+0000: Reference nan count: 0/3209956 (0.000%)
[INFO|validate|L358] 2024-09-09T18:38:56+0000: Mean absolute re-wrapped phase error: 0.00003 rad
[INFO|validate|L359] 2024-09-09T18:38:56+0000: Max absolute re-wrapped phase error: 0.00519 rad
[INFO|validate|L363] 2024-09-09T18:38:56+0000: Non-congruent pixel count: 1/3209933 (0.000%)
Traceback (most recent call last):
File "/opt/conda/bin/disp-s1", line 8, in <module>
sys.exit(cli_app())
^^^^^^^^^
File "/opt/conda/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/lib/python3.12/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/opt/conda/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/lib/python3.12/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/lib/python3.12/site-packages/disp_s1/cli/validate.py", line 15, in validate
compare(golden, test, data_dset)
File "/opt/conda/lib/python3.12/site-packages/disp_s1/validate.py", line 497, in compare
compare_groups(hf_g, hf_t)
File "/opt/conda/lib/python3.12/site-packages/disp_s1/validate.py", line 75, in compare_groups
_validate_displacement(
File "/opt/conda/lib/python3.12/site-packages/disp_s1/validate.py", line 373, in _validate_displacement
raise ComparisonError(errmsg)
disp_s1.validate.ComparisonError: unwrapped phase dataset '/displacement' failed validation: phase values were not congruent with reference dataset
Ticket to track new SAS delivery acceptance for version 0.4.3