nasa / opera-sds-pge

Observational Products for End-Users from Remote Sensing Analysis (OPERA)
Apache License 2.0
16 stars 6 forks source link

[Bug]: Unset ISO XML template field in runconfig leads to uncaught TypeError #512

Closed RKuttruff closed 1 month ago

RKuttruff commented 1 month ago

Checked for duplicates

Yes - I've already checked

Describe the bug

The field for the ISO XML template in the runconfig is optional (a necessity when developing Interface-stage PGEs), but there is no check for whether this is set or not in all current PGEs, which expect it to be set and exist, leading to a TypeError when trying to resolve its absolute path: os.path.abspath(None)

What did you expect?

In the event the template is missing, but is needed in a given PGE, the PGE should fail gracefully with an informative error message.

Reproducible steps

1. Produce a RunConfig YAML file with the `RunConfig.Groups.PGE.PrimaryExecutable.IsoTemplatePath` absent.
2. Run the PGE

Environment

No response

collinss-jpl commented 1 month ago

Closed by #513