nasa / prog_models

The NASA Prognostic Model Package is a Python framework focused on defining and building models for prognostics (computation of remaining useful life) of engineering systems, and provides a set of prognostics models for select components developed within this framework, suitable for use in prognostics applications for these components.
123 stars 50 forks source link

Updated exceptions #545

Closed teubert closed 1 year ago

teubert commented 1 year ago

Update exceptions to use default python exceptions

github-actions[bot] commented 1 year ago

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

github-actions[bot] commented 1 year ago
Benchmarking Results From: Test Time (s)
import main 0.15010079999999992
import thrown object 0.6007752
model initialization 0.14064799999999988
set noise 0.7340917
simulate 0.3616577000000003
simulate with saving 1.0663668999999998
simulate with saving, dt 1.2295367000000006
simulate with printing results, dt 1.4912909
Plot results 16.7774335
Metrics 0.0432465999999998
Surrogate Model Generation 3.682519899999999
surrogate sim 1.2461835000000008
surrogate sim, dt 3.472837900000002
To: Test Time (s)
import main 0.1524207000000002
import thrown object 0.6089762000000003
model initialization 0.14244220000000007
set noise 0.7655787000000003
simulate 0.3404243
simulate with saving 1.0877982000000004
simulate with saving, dt 1.1535173999999992
simulate with printing results, dt 1.3947968
Plot results 16.7437033
Metrics 0.041974400000000855
Surrogate Model Generation 3.726906800000002
surrogate sim 1.1951119000000006
surrogate sim, dt 3.3160951999999995
codecov-commenter commented 1 year ago

Codecov Report

Merging #545 (8c61a5f) into dev (b5edcc3) will increase coverage by 0.05%. The diff coverage is 57.77%.

@@            Coverage Diff             @@
##              dev     #545      +/-   ##
==========================================
+ Coverage   79.95%   80.00%   +0.05%     
==========================================
  Files          31       31              
  Lines        2484     2471      -13     
==========================================
- Hits         1986     1977       -9     
+ Misses        498      494       -4     
Impacted Files Coverage Δ
src/prog_models/__init__.py 100.00% <ø> (ø)
src/prog_models/exceptions.py 100.00% <ø> (ø)
src/prog_models/prognostics_model.py 83.03% <55.26%> (+0.55%) :arrow_up:
src/prog_models/utils/parameters.py 84.67% <66.66%> (-0.13%) :arrow_down:
src/prog_models/utils/containers.py 87.17% <100.00%> (-0.17%) :arrow_down:
github-actions[bot] commented 1 year ago
Benchmarking Results [Update] From: Test Time (s)
import main 0.13063899999999995
import thrown object 0.5024354
model initialization 0.12405149999999998
set noise 0.6870129999999999
simulate 0.30310250000000005
simulate with saving 0.9573337000000004
simulate with saving, dt 1.0471705000000004
simulate with printing results, dt 1.2544205999999996
Plot results 14.7942096
Metrics 0.036108099999999865
Surrogate Model Generation 3.238040599999998
surrogate sim 1.099964
surrogate sim, dt 2.9740889000000017

To:

Test Time (s)
import main 0.12886620000000004
import thrown object 0.5062948999999999
model initialization 0.12139949999999988
set noise 0.650279
simulate 0.30275870000000005
simulate with saving 0.9535556999999999
simulate with saving, dt 1.0397536
simulate with printing results, dt 1.2642156
Plot results 14.7463616
Metrics 0.03600850000000122
Surrogate Model Generation 3.3226723000000007
surrogate sim 1.0967160000000007
surrogate sim, dt 2.9691662
github-actions[bot] commented 1 year ago
Benchmarking Results [Update] From: Test Time (s)
import main 0.16543680000000016
import thrown object 0.6001236999999999
model initialization 0.14168069999999977
set noise 0.8067004999999998
simulate 0.34783169999999997
simulate with saving 1.0890307000000004
simulate with saving, dt 1.1845309000000004
simulate with printing results, dt 1.4535001999999997
Plot results 17.876660100000002
Metrics 0.0436704999999975
Surrogate Model Generation 3.8293475999999984
surrogate sim 1.2630444000000018
surrogate sim, dt 3.4058867

To:

Test Time (s)
import main 0.15404839999999997
import thrown object 0.5987399
model initialization 0.1415709999999999
set noise 0.7807138999999998
simulate 0.3458226
simulate with saving 1.0836949999999996
simulate with saving, dt 1.1883065000000004
simulate with printing results, dt 1.4492795000000003
Plot results 17.7424515
Metrics 0.0428890000000024
Surrogate Model Generation 3.921082300000002
surrogate sim 1.2612829999999988
surrogate sim, dt 3.4314351000000016
github-actions[bot] commented 1 year ago
Benchmarking Results [Update] From: Test Time (s)
import main 0.12440899999999999
import thrown object 0.5071474999999999
model initialization 0.1181833000000001
set noise 0.6840079000000001
simulate 0.3052035000000002
simulate with saving 0.9337642000000002
simulate with saving, dt 1.0338934999999996
simulate with printing results, dt 1.2519966999999994
Plot results 14.233220499999998
Metrics 0.039900800000001624
Surrogate Model Generation 3.2338367000000012
surrogate sim 1.0028058000000009
surrogate sim, dt 2.893364799999997

To:

Test Time (s)
import main 0.1281188999999998
import thrown object 0.5063322000000001
model initialization 0.11596110000000004
set noise 0.6762388000000001
simulate 0.30024229999999985
simulate with saving 0.9242582000000001
simulate with saving, dt 1.0300916000000004
simulate with printing results, dt 1.2453965999999994
Plot results 14.6131213
Metrics 0.041427299999998723
Surrogate Model Generation 3.3452801999999977
surrogate sim 1.0004045999999995
surrogate sim, dt 2.890265300000003