Closed teubert closed 1 year ago
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
Benchmarking Results From: | Test | Time (s) |
---|---|---|
import main | 0.1204035 | |
import thrown object | 0.49272040000000006 | |
model initialization | 0.11916929999999981 | |
set noise | 0.6700317 | |
simulate | 0.2961448999999998 | |
simulate with saving | 0.9046688999999999 | |
simulate with saving, dt | 1.0183152999999998 | |
simulate with printing results, dt | 1.2246209000000006 | |
Plot results | 14.054594400000001 | |
Metrics | 0.03917979999999943 | |
Surrogate Model Generation | 1.5820334000000003 | |
surrogate sim | 0.9868838999999987 | |
surrogate sim, dt | 2.8488235000000017 |
To: | Test | Time (s) |
---|---|---|
import main | 0.1148705000000001 | |
import thrown object | 0.5179172000000001 | |
model initialization | 0.1168003999999998 | |
set noise | 0.6866931000000001 | |
simulate | 0.2963342 | |
simulate with saving | 0.9101064000000001 | |
simulate with saving, dt | 1.0109920999999997 | |
simulate with printing results, dt | 1.2254330000000007 | |
Plot results | 14.0276055 | |
Metrics | 0.038784599999999614 | |
Surrogate Model Generation | 1.5772700999999998 | |
surrogate sim | 0.9825640999999976 | |
surrogate sim, dt | 2.848751199999999 |
Merging #556 (8cec2b7) into dev (d9fab24) will decrease coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## dev #556 +/- ##
==========================================
- Coverage 84.61% 84.56% -0.05%
==========================================
Files 34 34
Lines 2509 2501 -8
==========================================
- Hits 2123 2115 -8
Misses 386 386
Impacted Files | Coverage Δ | |
---|---|---|
src/prog_models/models/battery_electrochem.py | 78.36% <ø> (-0.81%) |
:arrow_down: |
Replaced by https://github.com/nasa/progpy/pull/67
Gage identified some unused parameters in BatteryElectroChemEOD. This PR removes those.