nasa / prog_models

The NASA Prognostic Model Package is a Python framework focused on defining and building models for prognostics (computation of remaining useful life) of engineering systems, and provides a set of prognostics models for select components developed within this framework, suitable for use in prognostics applications for these components.
123 stars 50 forks source link

Hotfix v1.5.1 #576

Closed teubert closed 1 year ago

teubert commented 1 year ago

3 important fixes

github-actions[bot] commented 1 year ago
Benchmarking Results From: Test Time (s)
import main 0.14266610000000002
import thrown object 0.5350619999999999
model initialization 0.16534249999999995
set noise 0.6976852
simulate 0.5193006999999996
simulate with saving 1.4649469000000002
simulate with saving, dt 1.8865004999999995
simulate with printing results, dt 2.3577375000000007
Plot results 15.5276378
Metrics 0.038735600000002535
Surrogate Model Generation 2.2723355000000005
surrogate sim 1.5062193000000015
surrogate sim, dt 3.8928645999999993
To: Test Time (s)
import main 0.1421551000000001
import thrown object 0.5385128000000001
model initialization 0.1667683000000002
set noise 0.7021822000000002
simulate 0.5103857999999999
simulate with saving 1.4513618000000004
simulate with saving, dt 1.865068
simulate with printing results, dt 2.3280955000000008
Plot results 15.520127700000002
Metrics 0.03862829999999917
Surrogate Model Generation 2.286378299999999
surrogate sim 1.510387699999999
surrogate sim, dt 3.870807199999998
github-actions[bot] commented 1 year ago
Benchmarking Results [Update] From: Test Time (s)
import main 0.13583600000000007
import thrown object 0.5491122000000002
model initialization 0.20291389999999976
set noise 0.7648516000000001
simulate 0.6357103
simulate with saving 1.8313377000000002
simulate with saving, dt 2.3198978000000006
simulate with printing results, dt 3.0084072000000006
Plot results 19.6663234
Metrics 0.04170050000000103
Surrogate Model Generation 2.8952479999999987
surrogate sim 2.0908748999999958
surrogate sim, dt 4.846682400000006

To:

Test Time (s)
import main 0.14331629999999995
import thrown object 0.5719700000000001
model initialization 0.20541429999999972
set noise 0.7615951000000001
simulate 0.6461519
simulate with saving 1.8459455999999999
simulate with saving, dt 2.3051745000000006
simulate with printing results, dt 3.0235769999999995
Plot results 19.755031600000002
Metrics 0.04170129999999972
Surrogate Model Generation 2.8063937000000045
surrogate sim 2.076211800000003
surrogate sim, dt 4.7435349
codecov-commenter commented 1 year ago

Codecov Report

Merging #576 (0766f34) into master (42b62d7) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files          45       45           
  Lines        3504     3504           
=======================================
  Hits         2961     2961           
  Misses        543      543           
Impacted Files Coverage Δ
src/prog_models/prognostics_model.py 85.63% <100.00%> (ø)
kjjarvis commented 1 year ago

Approving hotfix - all tests have passed and code has been reviewed

teubert commented 1 year ago

Also agree that this hot fix is ready for release