search

nasa / prog_models

The NASA Prognostic Model Package is a Python framework focused on defining and building models for prognostics (computation of remaining useful life) of engineering systems, and provides a set of prognostics models for select components developed within this framework, suitable for use in prognostics applications for these components.
123 stars 50 forks source link

Hotfix v1.5.2 #580

Closed teubert closed 1 year ago

teubert commented 1 year ago

Fix issue where LSTM breaks down with new version of tensorflow.

Issue is in the model saving and loading interface, which is optional. I removed this for the hotfix.

github-actions[bot] commented 1 year ago
Benchmarking Results From: Test Time (s)
import main 0.17167599999999994
import thrown object 0.6432239
model initialization 0.23196400000000006
set noise 0.8663327000000001
simulate 0.7385612000000004
simulate with saving 2.0258502
simulate with saving, dt 2.5853729999999997
simulate with printing results, dt 3.349795500000001
Plot results 22.9502044
Metrics 0.052859800000000234
Surrogate Model Generation 3.4671082999999996
surrogate sim 2.3468576
surrogate sim, dt 5.6150175
To: Test Time (s)
import main 0.1623741999999997
import thrown object 0.6387551
model initialization 0.23851159999999982
set noise 0.8541146999999998
simulate 0.7155123000000003
simulate with saving 2.035281800000001
simulate with saving, dt 2.7853214
simulate with printing results, dt 3.377644700000001
Plot results 22.6386745
Metrics 0.04841640000000069
Surrogate Model Generation 3.3728156999999968
surrogate sim 2.3139421999999996
surrogate sim, dt 5.496208699999997
codecov-commenter commented 1 year ago

Codecov Report

Merging #580 (1d56232) into master (03e23a9) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files          45       45           
  Lines        3504     3504           
=======================================
  Hits         2961     2961           
  Misses        543      543
Impacted Files Coverage Δ
src/prog_models/__init__.py 100.00% <100.00%> (ø)
kjjarvis commented 1 year ago

Hotfix approved. Nice bugfix and all tests are passing