search

nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.
https://nasa.github.io/progpy/
Other
65 stars 9 forks source link

Drop requirement that EnsembleModel have 2 models #11

Closed teubert closed 1 year ago

teubert commented 1 year ago

Requirement Text Ensemble model shall allow creation with one model

Background Information in v1.5, EnsembleModel artificially rejected creation with <2 models

Suggested Solution Remove check

Note Suggestion from v1.5 release review

DoD

Ashwani132003 commented 1 year ago

Hi, I had resolved this, now ensemble model will raise error only if 0 models are passed.

Here are the screenshots for changes made by me: 1) in ensemble_model.py at line 38-39 image 2)in test_ensemble.py at lines 30-33 image

tests are passing. Raising error when 0 models are passed.

This is going to be my first contribution to any of Nasa's repos. I want to ask if there is something additional needs to be done from my side before creating the pr? and where should i create the pr, in this repo itself or in nasa/prog_models ? waiting for your reply thanks .

teubert commented 1 year ago

Hello @Ashwani132003,

Great to meet you and thank you for your interest in contributing to ProgPy. Before we can accept any contributions, you do need to complete a contributors license agreement here: https://github.com/nasa/progpy/tree/master/forms

Use the individual if you're contributing as an individual and the corporate if you're contributing as part of funded work by some organization. You can email that to christopher.a.teubert@nasa.gov

Once you've done that you can open a PR in this repo (ProgPy), branching off of dev. At that point we will provide any review comments on your contributions.

Thanks again for your contributions.

teubert commented 1 year ago

Resolved by @Ashwani132003. Thank you @Ashwani132003 for your help