Closed teubert closed 8 months ago
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
28dd429
) 83.36% compared to head (51ce763
) 83.41%.
Files | Patch % | Lines |
---|---|---|
src/progpy/composite_model.py | 96.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
prog_server requires copying a model. This functionality is broken for composite model.
Fixed issue by moving more logic into setstate, which is called at construction and deepcopy (unlike init). Also added tests to catch this in the future