nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.
https://nasa.github.io/progpy/
Other
52 stars 7 forks source link

[Closes #129] Fixes issue with deepcopy in composite model #130

Closed teubert closed 8 months ago

teubert commented 8 months ago

prog_server requires copying a model. This functionality is broken for composite model.

Fixed issue by moving more logic into setstate, which is called at construction and deepcopy (unlike init). Also added tests to catch this in the future

github-actions[bot] commented 8 months ago

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

codecov-commenter commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (28dd429) 83.36% compared to head (51ce763) 83.41%.

Files Patch % Lines
src/progpy/composite_model.py 96.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #130 +/- ## ========================================== + Coverage 83.36% 83.41% +0.05% ========================================== Files 100 100 Lines 10428 10462 +34 ========================================== + Hits 8693 8727 +34 Misses 1735 1735 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.