nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.
https://nasa.github.io/progpy/
Other
52 stars 7 forks source link

Rename `threshold_keys` #147

Closed teubert closed 1 month ago

teubert commented 1 month ago

Rename threshold_keys to events to align with terminology in predictor. threshold_keys will still work, but will warn. added test and updated examples

github-actions[bot] commented 1 month ago

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.36%. Comparing base (0980f8c) to head (1ace59a). Report is 37 commits behind head on dev.

Files Patch % Lines
src/progpy/prognostics_model.py 81.81% 4 Missing :warning:
src/progpy/data_models/lstm_model.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #147 +/- ## ========================================== - Coverage 83.41% 83.36% -0.06% ========================================== Files 100 100 Lines 10462 10553 +91 ========================================== + Hits 8727 8797 +70 - Misses 1735 1756 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.