[Closes #146] Simulation/Prediction Ending Strategy

nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.

https://nasa.github.io/progpy/

Other

65 stars 9 forks source link

[Closes #146] Simulation/Prediction Ending Strategy #149

Closed teubert closed 4 months ago

teubert commented 4 months ago

Add a method of specifying a "strategy" for ending simulation and prediction. This is called the "event_strategy", and can be one of the following: 'first': Stop when the first event of the list is met 'all': Stop when all events in the list are met

Also added tests and added to tutorial.

Note: UTP is setup to only support 'all'. If you specify anything else, it will return an error. #150 opened to eventually add this functionality

github-actions[bot] commented 4 months ago

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

[ ] Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
[ ] Ensure that each PR adding a new feature should include a test verifying that feature.
[ ] All errors from static analysis must be resolved.
[ ] Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
[ ] Review the software benchmarking results (if there is a change) - will be added as comment on PR
[ ] Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
[ ] All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.40%. Comparing base (0980f8c) to head (fe8318d). Report is 42 commits behind head on dev.

Files	Patch %	Lines
src/progpy/predictors/monte_carlo.py	81.81%	2 Missing :warning:
src/progpy/prognostics_model.py	84.61%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #149 +/- ## ========================================== - Coverage 83.41% 83.40% -0.01% ========================================== Files 100 100 Lines 10462 10601 +139 ========================================== + Hits 8727 8842 +115 - Misses 1735 1759 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.