search

nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.
https://nasa.github.io/progpy/
Other
55 stars 8 forks source link

Consider renaming simulate_to_threshold #87

Closed teubert closed 11 months ago

teubert commented 1 year ago

Simulate_to_threshold is a function in progpy that simulates a model until some event is met. Then the user can indicate which events using threshold_keys.

There was some question about if it would be clearer to call this simulate_to_event and events, respectively.

Consider this option, collecting inputs. Then implement the change if desired.

teubert commented 11 months ago

Talked this over with @kjjarvis . simulate_to_event correlates better to the "events" vocabulary. However, simulate_to_threshold draws the connection to threshold_met and to the function naming in prognostics model library. For that reason we decided not to make this change