nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.
https://nasa.github.io/progpy/
Other
55 stars 8 forks source link

Move Memory Allocation in PF #92

Closed teubert closed 1 year ago

teubert commented 1 year ago

Very Minor PR

Move line where we reserve the memory for the output into the non-vectorized conditional. This memory is not used in vectorized case. In that case we allocate the memory when calling output instead. This makes that case very slightly faster.

Identified this opportunity when debugging with @mstraut

github-actions[bot] commented 1 year ago

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following: