Wedge load noise - Githubissues

nasa / progpy

The NASA Prognostic Python Packages is a Python framework focused on defining and building models and algorit for prognostics (computation of remaining useful life) of engineering systems, and provides a set of models and algorithms for select components developed within this framework, suitable for use in prognostic applications.

https://nasa.github.io/progpy/

Other

65 stars 9 forks source link

Wedge load noise #97

Closed teubert closed 1 year ago

teubert commented 1 year ago

Add "wedge noise" - that is, noise that increases the further we are in the future.

This is an important feature as it allows us to represent how our uncertainty in the future load increases the further out we are.

Also, renamed GaussianNoiseLoadWrapper to GaussianNoiseWrapper for conciseness. It's still in the loading sub package (progpy.loading.GaussianNoiseWrapper) so "Load" wasn't necessary. I leave an alias for backwards compatibility, but the documentation and examples will use GaussianNoiseWrapper.

Closes #84

github-actions[bot] commented 1 year ago

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

[ ] Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
[ ] Ensure that each PR adding a new feature should include a test verifying that feature.
[ ] All errors from static analysis must be resolved.
[ ] Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
[ ] Review the software benchmarking results (if there is a change) - will be added as comment on PR
[ ] Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
[ ] All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

codecov-commenter commented 1 year ago

Codecov Report

Merging #97 (1057c3c) into dev (0c23145) will decrease coverage by 0.03%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev      #97      +/-   ##
==========================================
- Coverage   84.22%   84.19%   -0.03%     
==========================================
  Files          99       99              
  Lines       10179    10183       +4     
==========================================
+ Hits         8573     8574       +1     
- Misses       1606     1609       +3

Files Changed	Coverage Δ
src/progpy/loading/gaussian_wrapper.py	`37.50% <42.85%> (-4.17%)`	:arrow_down:
src/progpy/loading/__init__.py	`100.00% <100.00%> (ø)`