Add vcrpy cassettes for revision_date unit tests

nasa / python_cmr

Python library for querying the common metadata repository.

MIT License

24 stars 22 forks source link

Add vcrpy cassettes for revision_date unit tests #70

Closed chuckwondo closed 4 months ago

chuckwondo commented 4 months ago

New unit tests recently added for testing new revision_date search functionality are missing vcrpy cassettes to prevent unit tests from making live requests. This can lead to broken tests in the future, should the responses change.

Specifically, these tests need to be supported by vcrpy cassettes:

test_revision_date in tests/test_collection.py
test_revision_date in tests/test_granule.py

frankinspace commented 4 months ago

@chuckwondo it doesn't like any of the test functions in tests/test_collection.py or tests/test_granule.py are using vcrpy as far as I can tell? We should add it for all these tests in that case.

chuckwondo commented 4 months ago

@chuckwondo it doesn't like any of the test functions in tests/test_collection.py or tests/test_granule.py are using vcrpy as far as I can tell? We should add it for all these tests in that case.

Correct. We haven't needed to use it in those files yet, as none of the tests make any http requests. Only the new tests for revision date actually make http requests. The rest of the tests simply construct query instances without actually executing the queries.