search

nasa / python_cmr

Python library for querying the common metadata repository.
MIT License
24 stars 22 forks source link

Add methods for setting parameter options #75

Closed miabobia closed 1 month ago

miabobia commented 1 month ago

Implemented requested changes from Issue #74 Added unit tests for said methods as well.

chuckwondo commented 1 month ago

Nicely done! For future reference, when changes are requested for your PR, you make the requested changes, and you're ready for the reviewer to review all of your updates, click the circular pair of arrows icon to prompt the reviewer to take another look (i.e., the icon that the big red arrow below points to). Since you might very well make multiple new commits to address the requested changes, it is not obvious to the reviewer when you're done with your changes until you press that icon, which explicitly indicates that you're done and ready for a re-review.

image

chuckwondo commented 1 month ago

@frankinspace, I've approved this PR, but please have a look to make sure you're also happy with it.

miabobia commented 1 month ago

Nicely done! For future reference, when changes are requested for your PR, you make the requested changes, and you're ready for the reviewer to review all of your updates, click the circular pair of arrows icon to prompt the reviewer to take another look (i.e., the icon that the big red arrow below points to). Since you might very well make multiple new commits to address the requested changes, it is not obvious to the reviewer when you're done with your changes until you press that icon, which explicitly indicates that you're done and ready for a re-review.

This is great to know for the future thank you :)