search

nasa / radbelt

radbelt: An Astropy-friendly wrapper for the AE-8/AP-8 Van Allen belt model
Other
28 stars 9 forks source link

Possible bug in SHELLG? #71

Closed jacobwilliams closed 5 months ago

jacobwilliams commented 5 months ago

FYI

In SHELLG, it seems that the U is never given any values but it used later in the code. What is the intended value of this array in this case?

U only seems to be given values if you call the entry point SHELLC, which doesn't seem ever to be called here.

Perhaps the code is assuming that the compiler will initialize U to all zeros? That's a non-standard assumptions and is not true in general (but might be true for some Fortran compilers, or maybe f2py is adding a compile flag to make that true?).

jacobwilliams commented 5 months ago

Never mind. It's actually an obsolescent feature, but u is set to those values initially whether or not SHELLC is called.