search

nasa / radbelt

radbelt: An Astropy-friendly wrapper for the AE-8/AP-8 Van Allen belt model
Other
28 stars 9 forks source link

Bug in aep8 #73

Closed jacobwilliams closed 4 months ago

jacobwilliams commented 4 months ago

https://github.com/nasa/radbelt/blob/75fbf407b5a62faaa152d6f8d819cca43cf38675/radbelt/core.f#L50

This IER in AEP8 should be IERR. IER is never given a value, so it can be anything.

lpsinger commented 4 months ago

I'm not much of a FORTRAN programmer. Is it also a problem that IERR is not defined?

jacobwilliams commented 4 months ago

IERR was an integer (since the Fortran implicit typing rules are in effect since this function doesn't have implicit none), and given a value by the OPEN call, so that was fine. It doesn't hurt to explicitly define it as you have done.