search

nasa / sitepod

A Sitemap Generator written in PHP
GNU General Public License v3.0
24 stars 16 forks source link

ISSUE-27 Fix licensing headers #28

Closed lewismc closed 7 years ago

lewismc commented 7 years ago

This issue addresses #27

sigee commented 7 years ago

It is fine. :+1: Just a mention: What do you think about phpDoc @license?

lewismc commented 7 years ago

@sigee I like phpDoc much better. I am closing this issue and we can implement the build and documentation using the notation from phpDoc. Do you know if we can tie it in to the CI process... something like readthedocs.io?

sigee commented 7 years ago

@lewismc, I've never used that service. I know composer can run scripts after install command for example. https://getcomposer.org/doc/articles/scripts.md#what-is-a-script- If we add phpdocumentor/phpdocumentor to the dependencies, we can call it after composer commands. It is a basic solution, so maybe readthedocs.io is a better one, but I don't know it yet.

lewismc commented 7 years ago

I just found the following article @sigee https://blog.cloudobjects.io/coding/opensource/2017/05/19/php-sdk-documentation/ I think this is what we could set up!