nasa / sitepod

A Sitemap Generator written in PHP
GNU General Public License v3.0
24 stars 16 forks source link

ISSUE-2 add CLI to allow easier automation #37

Closed lewismc closed 5 years ago

lewismc commented 6 years ago

The presence of the ISSUE-2 branch was breaking out Packagist.org compliance. Instead of maintaining it as a branch, this opens a PR for review by the team. @eniad FYI thanks for the PR.

lewismc commented 6 years ago

@eniad I am thinking that some documentation to accompany this PR would be helpful. Naybe we can augment the README wdyt?

sigee commented 6 years ago

@lewismc, @eniad, What is it exactly? I mean a CLI is not equal with the CRON script.

lewismc commented 6 years ago

Hi @sigee I went ahead and removed the unnecessary comments. We still import the /cron.php however. What are you comments on the current PR? Thanks you and sorry for the late response.

lewismc commented 6 years ago

@sigee ping if you have time to review...

sigee commented 5 years ago

@lewismc It seems a bit better, but I still not know why the whole cron.php is needed. If so than it is OK till a "small" refactor.