nasa / stitchee

Harmony service that concatenates netCDF4 data files along an existing dimension
https://stitchee.readthedocs.io/
Apache License 2.0
6 stars 0 forks source link

Feature/issue 198 ordered output #221

Closed danielfromearth closed 4 months ago

danielfromearth commented 4 months ago

GitHub Issue: #198

Description

This changes the sorting of datasets from using the concatenation dimension (with a current default of mirror_step), to using a time_variable, which can be specified as an argument to the stitchee() function.

Local test steps

Passed automated CI tests run locally.

Overview of integration done

Passed automated CI integration tests.

PR Acceptance Checklist

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.01%. Comparing base (9b28863) to head (391e4e0). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #221 +/- ## =========================================== + Coverage 84.92% 85.01% +0.09% =========================================== Files 11 11 Lines 630 634 +4 =========================================== + Hits 535 539 +4 Misses 95 95 ``` | [Flag](https://app.codecov.io/gh/nasa/stitchee/pull/221/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/nasa/stitchee/pull/221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | `44.95% <100.00%> (+0.34%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/nasa/stitchee/pull/221/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa) | `82.49% <100.00%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ank1m commented 4 months ago

image image