search

nasa / to_lab

The Core Flight System (cFS) Telemetry Output Lab App (to_lab)
Apache License 2.0
26 stars 41 forks source link

Refactor mutually exclusive if in TO_LAB_init() #145

Closed thnkslprpt closed 1 year ago

thnkslprpt commented 1 year ago

Describe the bug Mutually exclusive logic in this if, else if, and also no final else clause which I believe is frowned upon in the coding guidelines.

Code snips https://github.com/nasa/to_lab/blob/7ca124c7e9d4a4086714525e3db2869a7da059b1/fsw/src/to_lab_app.c#L203-L215

Expected behavior Refactor into a simpler if, else block.

Reporter Info Avi Weiss @thnkslprpt