search

nasa / trick

Trick Simulation Environment. Trick provides a common set of simulation capabilities and utilities to build simulations automatically.
Other
34 stars 19 forks source link

binary data from variable server does not convert units #1074

Open spfennell opened 3 years ago

spfennell commented 3 years ago

write_binary_data does no udunits conversion.

vs_format_ascii uses udunits convert functions and var->conversion_factor when writing data. replicate this functionality in write_binary_data or in a separate function.

spfennell commented 1 year ago

This issue can be closed when write_binary_data also implements unit conversion the same way vs_format_ascii does.

Pherring04 commented 1 month ago

I believe we can close this issue. write_binary_data only writes bitfields, which are not converted in write_ascii_data either.