nasa / trick

Trick Simulation Environment. Trick provides a common set of simulation capabilities and utilities to build simulations automatically.
Other
34 stars 19 forks source link

Uninitialized variables #1558

Open dandexter opened 1 year ago

dandexter commented 1 year ago

File: trick_source/sim_services/Sie/Sie.cpp Line: 205 Issue: The 'pos' variable is defined on line 191 but is never initialized to any value before it is used on line 205 "sie_out.seekg(pos - 1);".

File: trick_source/sim_services/DataTypes/src/EnumDataType.cpp Line: 162 Issue: The 'value' is not initialized in the case of an error on line 147. The 'value' needs to be set to something in the error case because the code below depends on 'value' being set to something.

File: trick_source/trick_utils/SAIntegrator/unittest/RKF45Integrator_unittest.cc Line: 27 Issue: Although the 'result' variable was declared on line 25, it has not been initialized with a value before it is used on line 27: double* state[1] = { &result };

File: trick_source/trick_utils/SAIntegrator/src/SAIntegrator.cpp Line: 296 Issue: The 'new_h' variable was declared on line 287 but is not initialized with a value before is is used on line 290: variable_step(h-new_h);

File: trick_source/data_products/Apps/ExternalPrograms/dp_euler_ang.c Lines 52, 53, 54 Issue: Using arrays i, j, and k, which are allocated but have not been initialized.

File: trick_source/data_products/Apps/ExternalPrograms/dp_inrtl_attitude.c Lines: 50, 51, 52 Issue: Using arrays i, j, and k, which are allocated but have not been initialized.

File: trick_source/data_products/Apps/ExternalPrograms/dp_quat_inrtl_attitude.c Lines: 54, 55, 56 Issue: Using arrays i, j, and k, which are allocated but have not been initialized.

File: trick_source/data_products/Apps/ExternalPrograms/dp_lvlh_attitude.c Lines: 56, 57, 58 Issue: Using arrays i, j, and k, which are allocated but have not been initialized.

File: trick_source/data_products/Apps/ExternalPrograms/dp_quat_lvlh_attitude.c Lines: 58, 59, 60 Issue: Using arrays i, j, and k, which are allocated but have not been initialized.

FIle: trick_source/data_products/Apps/ExternalPrograms/dp_payload_attitude.c Lines: 52, 53, 54 Issue: Using arrays i, j, and k, which are allocated but have not been initialized.

File: trick_source/trick_utils/SAIntegrator/examples/DefiniteIntegral/DefiniteIntegral.cpp Line: 40 Issue: The variable DI.result has not been initialized.

dandexter commented 10 months ago

What's the plan for getting this fixed?