search

nasa / trick

Trick Simulation Environment. Trick provides a common set of simulation capabilities and utilities to build simulations automatically.
Other
26 stars 15 forks source link

Trick prints warning for checkpoints outside of freeze mode. #1682

Closed Mrockwell2 closed 1 month ago

coveralls commented 3 months ago

Coverage Status

coverage: 56.182% (+0.2%) from 55.952% when pulling e538aecfe273c7390d89477da483313f39c35dd0 on Mrockwell2:1461-only-allow-dumping-and-loading-checkpoints-in-freeze-mode into d72312c6023fa36997eecb2ef7b5028c28f605d5 on nasa:master.

excaliburtb commented 3 months ago

i don't think this is true for generic cases. if you have some fully async threads running, then it might be a problem. otherwise, it is well-defined behavior. Perhaps you have a specific use case or example that illustrates the issue?

Mrockwell2 commented 2 months ago

i don't think this is true for generic cases. if you have some fully async threads running, then it might be a problem. otherwise, it is well-defined behavior. Perhaps you have a specific use case or example that illustrates the issue?

When you checkpoint a running sim without freezing and reload that checkpoint, the data recording log resumes on the next frame. So far that's the most glaring thing I've found, but I'll keep looking.

Mrockwell2 commented 1 month ago

The issue fix was better implemented in another branch. See this pull request (#1727 )