search

nasa / utm-apis

The collection of APIs for NASA's UTM project in the form of OpenAPI documents.
55 stars 35 forks source link

uss_id not a property of Operation #168

Closed shortwavedave closed 4 years ago

shortwavedave commented 4 years ago

In the USS api spec, for a put on '/operations/{gufi}', there is the note:

https://github.com/nasa/utm-apis/blob/f415e12f67c71e3aaaaec7dffa5a3838f0cf693d/uss-api/swagger.yaml#L602

However, there is no uss_id property defined in the Operation object in utm-domain-commons.yaml https://github.com/nasa/utm-apis/blob/f415e12f67c71e3aaaaec7dffa5a3838f0cf693d/utm-domains/utm-domain-commons.yaml#L338

Have I reconciled this note correctly? What is uss_id in reference to?

nasajoey commented 4 years ago

Looks like a typo.

Instead of Operation.uss_id == access_token.sub

We should have Operation.uss_name == access_token.sub in order to match the definition in commons.

Thanks for the links... I used them to check this quickly. If my answer doesn't make sense or if you think I may have mis-stated something, please follow up.

shortwavedave commented 4 years ago

Thanks @nasajoey I submitted a pull request, so I'll close this issue