search

nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
95 stars 28 forks source link

Notebook for computing change area estimates #179

Closed hannah-rae closed 1 year ago

hannah-rae commented 2 years ago

This notebook goes through the whole process of change area estimation between maps from two different years. Currently it stops at labeling the reference sample in CEO, but will be updated later to finish the actual change class area computations.

ivanzvonkov commented 2 years ago

Same test failure as #177, most likely tied to some update to python and mypy version interplay happening on the Github machines. @evamutz is addressing this in #177 by testing a newer version python (currently 3.6).

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ivanzvonkov commented 1 year ago

@hannah-rae let me know what you think of above comments!

hannah-rae commented 1 year ago

@ivanzvonkov Thanks for the feedback! I had this on the backburner for a bit but I'm working on it again now.

  • The change area notebook headings have a weird ordering (1,2,3,4,5,6,7,4,5,6) not sure if I am missing something here

Fixed (I seem to have started renumbering then abandoned it)

  • Would it make sense to align the notebook headings more closely with the description steps?

Fixed

  • Would it make sense to make a Github issue to "port" this to Colab and use assets directly from the cloud?

Good idea - I'll create this issue.

ivanzvonkov commented 1 year ago

One integration test is failing because data is outdated, will fix in https://github.com/nasaharvest/crop-mask/issues/183 and merge this.

@Aniket-Parlikar FYI